From 3c9e47ab34e01d03c2a7f05f23adf54c06535ab2 Mon Sep 17 00:00:00 2001 From: Hans Ott Date: Sun, 30 Oct 2016 16:50:19 +0100 Subject: [PATCH 1/2] Remove useless items from PR checklist These rules will be checked in the Travis build. --- PULL_REQUEST_TEMPLATE.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 4947c12..c0f119a 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -38,8 +38,6 @@ Please, please, please, don't send your pull request until all of the boxes are - [ ] I have created a branch for this patch/feature. - [ ] Each individual commit in the pull request is meaningful. - [ ] I have added tests to cover my changes. -- [ ] All new and existing tests passed. - [ ] If my change requires a change to the documentation, I have updated it accordingly. -- [ ] My code follows the code style of this project. If you're unsure about any of these, don't hesitate to ask. We're here to help! From 2964e5aedb5f1034bcfdc71f44a7d83241d54d02 Mon Sep 17 00:00:00 2001 From: Hans Ott Date: Tue, 1 Nov 2016 10:13:31 +0100 Subject: [PATCH 2/2] Add note about CI --- PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index c0f119a..86246b3 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -31,7 +31,7 @@ What types of changes does your code introduce? Put an `x` in all the boxes that Go over all the following points, and put an `x` in all the boxes that apply. -Please, please, please, don't send your pull request until all of the boxes are ticked. +Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our [continuous integration](http://www.phptherightway.com/#continuous-integration) server to make sure your [tests and code style pass](https://help.github.com/articles/about-required-status-checks/). - [ ] I have read the **[CONTRIBUTING](CONTRIBUTING.md)** document. - [ ] My pull request addresses exactly one patch/feature.